Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45746/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45746/2//COMMIT_MSG@12 PS2, Line 12: For variants that use spd_tools, add an empty mem_parts_used.txt so
Please add a blank line between paragraphs.
Done
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/volte... File util/mainboard/google/volteer/template/memory/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/volte... PS2, Line 4: ddr4
Volteer boards can use LPDDR4x or DDR4 memories. […]
I'll update the file to remove the comments that suggest that only DDR4 is supported.
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/volte... PS2, Line 9: , Fixed ID (optional)
Just a note: This is not supported by LPDDR4x tool. […]
I copied this one from Zork. I'll remove references to the Fixed ID and also the implication that only DDR4 is supported.
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/waddl... File util/mainboard/google/waddledee/template/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/waddl... PS2, Line 5: ddr4
Dedede boards do not use DDR4 memory.
There is no "empty" SPD for lpddr4x. I just need a placeholder here. Is the comment above (use spd_tools to regenerate this file) not enough?