Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44234 )
Change subject: cpu/intel/slot_1: Factor out per-CPU Kconfig
......................................................................
Patch Set 3: Code-Review+1
I thought about this, you made this happen. 😊
Although I would put some other patches in this train first, namely the one unifying 65x/67x and the one unifying 68x/6bx. But timeless binary doesn't change before and after, so you have my vote.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44234
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09a580850bc8dd9276b94d75c58cdd6382a44e2e
Gerrit-Change-Number: 44234
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 09 Aug 2020 04:12:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment