Venkateswarlu V Vinjamuri has posted comments on this change. ( https://review.coreboot.org/18947 )
Change subject: soc/intel/apollolake: Set sdcard card detect (CD) host ownership ......................................................................
Patch Set 6:
(2 comments)
will address rest of the comments in next version.
https://review.coreboot.org/#/c/18947/6/src/soc/intel/apollolake/gpio.c File src/soc/intel/apollolake/gpio.c:
PS6, Line 215: hostsw_reg_addr;
Just do this:
returns the following address 0x80, 0x84, 0x88. That's why it defined as 8bit.
https://review.coreboot.org/#/c/18947/6/src/soc/intel/apollolake/include/soc... File src/soc/intel/apollolake/include/soc/nvs.h:
Line 44: uint8_t hsad; /* 0x2F - HOSTSW_REG address */
Can you not calculate this HOSTW_REG in ACPI based on the relative the comm
scd0 is used to extract the rxstate from dw0 of gpio177 --> it's required.
hsad is used to get the offset of host owned register where the pin is present. -->this can be extracted in asl. It required some extra effort.