[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Hook up GMA ACPI brightness controls

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40593 )

Change subject: soc/intel/apollolake: Hook up GMA ACPI brightness controls
......................................................................

Patch Set 6: Code-Review-1
> Needs an update to include `gma.h`.
>
> Beside that, APL has different registers for the PWM configuration.
> There are two sets, all 32 bits:
> panel 1: freq 0xc8254, duty 0xc8258
> panel 2: freq 0xc8354, duty 0xc8358
>
> I suggest that we add a Kconfig INTEL_GMA_PANEL_2 and override things
> as follows:
> config INTEL_GMA_BCLV_OFFSET
>         default 0xc8358 if INTEL_GMA_PANEL_2
>         default 0xc8258
>
> config INTEL_GMA_BCLV_WIDTH
>         default 32
>
> config INTEL_GMA_BCLM_OFFSET
>         default 0xc8354 if INTEL_GMA_PANEL_2
>         default 0xc8254
>
> config INTEL_GMA_BCLM_WIDTH
>         default 32

Giving this a bump as it seems it was forgotten.