Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37361 )
Change subject: lib/imd_cbmem: Eliminate unnecessary NULL check
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37361/2/src/lib/imd_cbmem.c
File src/lib/imd_cbmem.c:
https://review.coreboot.org/c/coreboot/+/37361/2/src/lib/imd_cbmem.c@67
PS2, Line 67: * cbmem_top();
The global, imd_cbmem on line 46, needs to be initialized which it seems to be be in the cbmem_initialize() path. I believe this whole compilation unit can be dropped to rely on the global imd_cbmem.
Every sequence that calls imd_init_backing_with_recover() can be dropped and imd_init_backing() can be dropped as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37361
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9a9c88d6cd4842df447f046bc0abaa7ef5032c7
Gerrit-Change-Number: 37361
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 02 Dec 2019 20:39:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment