Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43949 )
Change subject: mb/google/dedede: Fix S3 wake using trackpad
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43949/3/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43949/3/src/mainboard/google/dedede...
PS3, Line 19: register "pmc_gpe0_dw0" = "PMC_GPP_B"
: register "pmc_gpe0_dw1" = "PMC_GPP_C"
: register "pmc_gpe0_dw2" = "PMC_GPP_D"
Can you please check if these groups have non-conflicting IRQs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43949
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58ce3720e0fdeefb2c9440bb3006897ef80211ea
Gerrit-Change-Number: 43949
Gerrit-PatchSet: 4
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 29 Jul 2020 07:19:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment