3 Jan
2023
3 Jan
'23
8:05 a.m.
Attention is currently required from: Tarun Tuli, Derek Huang, Caveh Jalali, Christian Walter, Nick Vaccaro, Daisuke Nojiri, Boris Mittelberg.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70773 )
Change subject: chromeos/cr50_enable_update.c: Clear EC AP_IDLE flag ......................................................................
Patch Set 14:
(1 comment)
File src/vendorcode/google/chromeos/cr50_enable_update.c:
https://review.coreboot.org/c/coreboot/+/70773/comment/c7c94e5a_47e9977b PS12, Line 171: poweroff(); the powerofff should stay in if (CONFIG(POWER_OFF_ON_CR50_UPDATE))?
--
To view, visit https://review.coreboot.org/c/coreboot/+/70773
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If97ffbe65f4783f17f4747a87b0bf89a2b021a3b
Gerrit-Change-Number: 70773
Gerrit-PatchSet: 14
Gerrit-Owner: Derek Huang derekhuang@google.com
Gerrit-Reviewer: Boris Mittelberg bmbm@google.com
Gerrit-Reviewer: Caveh Jalali caveh@chromium.org
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Daisuke Nojiri dnojiri@chromium.org
Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-CC: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Derek Huang derekhuang@google.com
Gerrit-Attention: Caveh Jalali caveh@chromium.org
Gerrit-Attention: Christian Walter christian.walter@9elements.com
Gerrit-Attention: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Attention: Daisuke Nojiri dnojiri@chromium.org
Gerrit-Attention: Boris Mittelberg bmbm@google.com
Gerrit-Comment-Date: Tue, 03 Jan 2023 08:05:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment