Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43418 )
Change subject: soc/amd/picasso: use FADT devicetree configuration options ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43418/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43418/1//COMMIT_MSG@19 PS1, Line 19: The fadt_pm_profile option is removed from this patch. See commit : 56da63c3dc3f50cfac541c779b608e1bae9e635c which removed overriding that : field.
Please use: […]
the referenced commit removed the preferred_pm_profile override, so that the option selected by SYSTEM_TYPE_* is used.
i consider using short hashes a rather bad idea; much bigger chance of collisions. if we have more bits, we shouldn't throw them away; sha1 already doesn't have that many bits. this usually gets converted into a clickable link, but the line break in between probably prevents that. i can add the summary line there, but don't see that much added value in that and i haven't seen that being done in other patches