Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32722 )
Change subject: lapic/lapic_cpu_init: Add cpu_add_map_entry() to store default_apic_id
......................................................................
Patch Set 3: Code-Review+2
This looks correct to me, but I would appreciate a second
opinion by somebody more familiar with this code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32722
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac4d6e9e6e6f9ba644335b4b70da8689c405f638
Gerrit-Change-Number: 32722
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 11 May 2019 12:44:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment