Attention is currently required from: Raul Rangel, Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42685 )
Change subject: soc/amd/common: Drop ACPIMMIO bank for SMBus device PCI config
......................................................................
Patch Set 9:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/42685/comment/03aec7fb_e1977acc
PS6, Line 7: Drop ACPIMMIO ban
Why have it if PCI config write does the same thing, with less confusion? If PSP did map this partic […]
Ack
https://review.coreboot.org/c/coreboot/+/42685/comment/b28c686f_a9b46e40
PS6, Line 10: PCI config write
No PCI config access from psp-verstage?
Ack
File src/soc/amd/picasso/uart.c:
https://review.coreboot.org/c/coreboot/+/42685/comment/f3250b23_f3d03863
PS8, Line 107: if (CONFIG(AMD_SOC_UART_1_8MZ)) {
if (ENV_X86 && CONFIG(AMD_SOC_UART_1_8MZ))
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42685
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c8ce8de0a6ab0ed41e7e8a5980d0f0510aaa993
Gerrit-Change-Number: 42685
Gerrit-PatchSet: 9
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 02 Feb 2021 06:22:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment