Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34384 )
Change subject: include/spi-generic: clean up FLASH TIMEOUTs ......................................................................
Patch Set 1: Code-Review+1
(5 comments)
https://review.coreboot.org/c/coreboot/+/34384/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34384/1//COMMIT_MSG@7 PS1, Line 7: include/spi-generic: clean up FLASH TIMEOUTs Maybe:
include/spi-generic: Append unit to time-out macro names
https://review.coreboot.org/c/coreboot/+/34384/1//COMMIT_MSG@9 PS1, Line 9: 983a2ef65c The hash will change, when the commit is committed to the master branch.
https://review.coreboot.org/c/coreboot/+/34384/1//COMMIT_MSG@9 PS1, Line 9: an a
https://review.coreboot.org/c/coreboot/+/34384/1//COMMIT_MSG@9 PS1, Line 9: follow up follow-up
https://review.coreboot.org/c/coreboot/+/34384/1//COMMIT_MSG@9 PS1, Line 9: This patch provides as follow up of patch 983a2ef65c an cleanup of : defines for FLASH TIMEOUTs and the following necessary changes in the : source files which use these defines. With the updated commit message, I’d just remove the description.