[coreboot-gerrit] Change in ...coreboot[master]: intel/apollolake: Add fixed resources for VTd to system resources

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30991 )

Change subject: intel/apollolake: Add fixed resources for VTd to system resources
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/30991/6/src/soc/intel/apollolake/systemagent... 
File src/soc/intel/apollolake/systemagent.c:

https://review.coreboot.org/#/c/30991/6/src/soc/intel/apollolake/systemagent... 
PS6, Line 53: 			      (MCHBAR32(GFXVTBAR) & VTBAR_MASK) / KiB,
> Yes, and we have just an "unsigned long" to pass to the mmio_resource(). […]

We are lucky here as the most significant 24 bits are defined to be
read-only zero. So when reading the 64-bit value, you'll actually
have only 40 bits, and minus 10 makes only 30 bits after converting
to KiB.

In case APL supports reading 64-bit values, this could be as simple
as changing 32 to 64 in this line (given a proper definition of
VTBAR_MASK).