Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35228 )
Change subject: src/soc/intel/{common,cnl,skl,icl}: Move global reset req function to common ......................................................................
Patch Set 25:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35228/25/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35228/25/src/soc/intel/common/block... PS25, Line 601: -1
All other functions return 0 on error and 1 on success. […]
It is addressed in the patch: https://review.coreboot.org/c/coreboot/+/37584/1
https://review.coreboot.org/c/coreboot/+/35228/25/src/soc/intel/common/block... PS25, Line 610: heci_send_receive(&msg, sizeof(msg), NULL, 0);
Why not use heci_send()?
Yes, we can use heci_send(). Code change adddressed in the patch: https://review.coreboot.org/c/coreboot/+/37584/1
https://review.coreboot.org/c/coreboot/+/35228/25/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35228/25/src/soc/intel/common/block... PS25, Line 114: rst_type
There should be a comment indicating that this rst_type is one of the definitions below. […]
Addressed in https://review.coreboot.org/c/coreboot/+/37584/1