Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44375 )
Change subject: libpayload: cbgfx: Add color mapping functionality
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
LGTM with one nit.
https://review.coreboot.org/c/coreboot/+/44375/1/payloads/libpayload/drivers...
File payloads/libpayload/drivers/video/graphics.c:
https://review.coreboot.org/c/coreboot/+/44375/1/payloads/libpayload/drivers...
PS1, Line 95: = {
: .alpha = 0,
: .rgb.red = 0,
: .rgb.green = 0,
: .rgb.blue = 0,
: };
Should we remove the initialization here to bring it in line with color_map?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44375
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I640ff3e8455cd4aaa5a41d03a0183dff282648a5
Gerrit-Change-Number: 44375
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 12 Aug 2020 17:52:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment