Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37324 )
Change subject: [WIP] soc/amd/common: Access ACPI MMIO via proper symbols ......................................................................
Patch Set 5:
(2 comments)
Only downside to this is that we're doing and extra read for every access to the bank instead of constants in the instruction stream.
https://review.coreboot.org/c/coreboot/+/37324/5/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/acpimmio_map.h:
https://review.coreboot.org/c/coreboot/+/37324/5/src/soc/amd/common/block/in... PS5, Line 48: #define ACPIMMIO_SM_PCI_BANK 0x0000 These are offsets. Should we name the macros accordingly?
https://review.coreboot.org/c/coreboot/+/37324/5/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/gpio_banks.h:
https://review.coreboot.org/c/coreboot/+/37324/5/src/soc/amd/common/block/in... PS5, Line 22: #define GPIO_BANK0_CONTROL(gpio) ((uintptr_t)acpimmio_gpio0 + ((gpio) * 4)) nit: add a '- 0' for the offset for consistency with the others?