Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34297 )
Change subject: [WIP] Enable -Wimplicit-fallthrough
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/34297/2/src/southbridge/amd/agesa/h...
File src/southbridge/amd/agesa/hudson/hudson.c:
https://review.coreboot.org/c/coreboot/+/34297/2/src/southbridge/amd/agesa/h...
PS2, Line 120: Fall
nit: capitalization intentional?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34297
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d75637a434a955a58d166ad203e49620d7395ed
Gerrit-Change-Number: 34297
Gerrit-PatchSet: 2
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 12 Jul 2019 23:47:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment