Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31333 )
Change subject: superio/nsc/pc87392: Use common early_serial ......................................................................
superio/nsc/pc87392: Use common early_serial
Change-Id: I9437ee3f8830dc831aacfc62b9dd1943b73b98d4 Signed-off-by: Peter Lemenkov lemenkov@gmail.com Reviewed-on: https://review.coreboot.org/c/31333 Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/superio/nsc/pc87392/Kconfig D src/superio/nsc/pc87392/early_serial.c 2 files changed, 1 insertion(+), 26 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/superio/nsc/pc87392/Kconfig b/src/superio/nsc/pc87392/Kconfig index f0f6fd0..adff8df 100644 --- a/src/superio/nsc/pc87392/Kconfig +++ b/src/superio/nsc/pc87392/Kconfig @@ -15,3 +15,4 @@
config SUPERIO_NSC_PC87392 bool + select SUPERIO_NSC_COMMON_PRE_RAM diff --git a/src/superio/nsc/pc87392/early_serial.c b/src/superio/nsc/pc87392/early_serial.c deleted file mode 100644 index f8eb255..0000000 --- a/src/superio/nsc/pc87392/early_serial.c +++ /dev/null @@ -1,26 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2011 Sven Schnelle svens@stackframe.org - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#include <arch/io.h> -#include "pc87392.h" - -static void pc87392_enable_serial(pnp_devfn_t dev, u16 iobase) -{ - pnp_set_logical_device(dev); - pnp_set_enable(dev, 0); - pnp_set_iobase(dev, PNP_IDX_IO0, iobase); - pnp_set_enable(dev, 1); -}