Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39018 )
Change subject: ec/google/chromeec: Introduce SKU_ID helpers ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39018/4/src/ec/google/chromeec/Kcon... File src/ec/google/chromeec/Kconfig:
https://review.coreboot.org/c/coreboot/+/39018/4/src/ec/google/chromeec/Kcon... PS4, Line 103: # set to 0xff for LEGACY : config EC_GOOGLE_CHROMEEC_SKUID_MAX : hex : default 0x7fffffff
It is required because boards need the ability to override to legacy
But where and how is it actually used?
For legacy boards: EC will only pass values upto 0xff and those will get exposed to the OS in SMBIOS.
For new boards: EC will pass values upto 0x7fffffff and those will get exposed to the OS in SMBIOS.
Does coreboot really need to know whether that MAX value is 0xff or 0x7fffffff?
https://review.coreboot.org/c/coreboot/+/39018/4/src/ec/google/chromeec/ec_s... File src/ec/google/chromeec/ec_skuid.c:
https://review.coreboot.org/c/coreboot/+/39018/4/src/ec/google/chromeec/ec_s... PS4, Line 34: google_chromeec_smbios_system_sku If you rename this smbios_system_sku, then you can avoid this https://review.coreboot.org/c/coreboot/+/39019/8/src/mainboard/google/hatch/....
Also, it wouldn't impact any other board since EC_GOOGLE_CHROMEEC_SKUID will not be selected for any board other that Google boards using Chrome EC.