Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46431 )
Change subject: mb/google/volteer: Update flashmap descriptor to add ME_RW_A/B region
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46431/7/src/mainboard/google/voltee...
File src/mainboard/google/volteer/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/46431/7/src/mainboard/google/voltee...
PS7, Line 15: 0x280000
Is there any growth anticipated in the size of the ME RW binary? Just noting here that we would have about 268 KiB free space left in ME_RW_A/_B with this change, whereas we'll have about 1.5MiB left in each FW_MAIN_A/_B section, so there's some room you could borrow from for future growth.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46431
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87da3824933ed2dd8e8ed0fed8686d2a3527faea
Gerrit-Change-Number: 46431
Gerrit-PatchSet: 7
Gerrit-Owner: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 16 Nov 2020 21:39:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment