[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Provide mmc.c for setting dll registers.

[Kane Chen (Code Review)]

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35040 )

Change subject: soc/intel/common/block: Provide mmc.c for setting dll registers.
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35040/5/src/soc/intel/common/block/... 
File src/soc/intel/common/block/scs/mmc.c:

https://review.coreboot.org/c/coreboot/+/35040/5/src/soc/intel/common/block/... 
PS5, Line 61: SOC_INTEL_COMMON_MMC_OVERRIDE
> Can zero be treated as a special value? Or do you expect 0 to be a valid value that can be used to s […]

Hi Furquan, 
Could we still have the Kconfig?

Here is the reason.

These dll settings in devtree will also be used after the newer FSP is landed.
The new dll UPDs value will be fed by the settings in devtree.

Once the new fsp is landed, if we use 0 as a condition to check, then this code will do duplicate things again.

So far i think this function is mainly to override the settings when FSP doesn't provide specific UPDs

After newer FSP is landed, we can turn off Kconfig and the code won't run duplicate things

Thanks.