Attention is currently required from: Nico Huber, Julius Werner, Michael Niewöhner, Werner Zeh.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49542 )
Change subject: [RFC] Documentation/coding_style: Clarify line limit for text blocks
......................................................................
Patch Set 1:
(1 comment)
File Documentation/coding_style.md:
https://review.coreboot.org/c/coreboot/+/49542/comment/6daa1399_182f1014
PS1, Line 97: the overall line length should not exceed 96 chars.
I also can't understand how that makes anything more complicated, for me it's the exact opposite. […]
Something that may be easier to achieve: try to make rectangular multi-line comments. That is, break the text so that the lines have about the same length. My blood boils when I see this:
/*
* This is a silly comment about some coreboot stuff that is slightly too long to fit on
* a single line.
*/
Instead, I much prefer this:
/*
* This is a silly comment about some coreboot stuff
* that is slightly too long to fit on a single line.
*/
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49542
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12485453721ff01299bba2ade910793f5a032045
Gerrit-Change-Number: 49542
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Tue, 02 Feb 2021 10:28:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment