11 Jul
2019
11 Jul
'19
8:21 p.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26169 )
Change subject: devicetree: Add USB device type ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/26169/3/src/device/device_util.c File src/device/device_util.c:
https://review.coreboot.org/c/coreboot/+/26169/3/src/device/device_util.c@26... PS3, Line 260: ||
Did you intend to use bit-wise OR or logical OR. […]
I think it should be bitwise OR.
--
To view, visit https://review.coreboot.org/c/coreboot/+/26169
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64e6eba503cdab49be393465b535e139a8c90ef4
Gerrit-Change-Number: 26169
Gerrit-PatchSet: 3
Gerrit-Owner: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Thu, 11 Jul 2019 18:21:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com
Gerrit-MessageType: comment