build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38507 )
Change subject: mb/intel/jasperlake_rvp: Add memory initialization parameters ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38507/1/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/38507/1/src/mainboard/intel/jasperl... PS1, Line 35: if(board_id == BOARD_ID_JSL_DDR4) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/38507/1/src/mainboard/intel/jasperl... PS1, Line 73: mem_cfg->CaVrefConfig = 0x2; /* VREF_CA->CHA/CHB */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/38507/1/src/mainboard/intel/jasperl... PS1, Line 74: mem_cfg->ECT = 1; /* Early Command Training Enabled */ please, no space before tabs