chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43408 )
Change subject: mb/google/zork: add dptc support ......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43408/9/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/dptc.asl:
https://review.coreboot.org/c/coreboot/+/43408/9/src/mainboard/google/zork/v... PS9, Line 29: If (_SB.PCI0.LPCB.EC0.RCTM == One) { Please add comments indicating what each method is for.
https://review.coreboot.org/c/coreboot/+/43408/9/src/mainboard/google/zork/v... PS9, Line 37: POF0 These methods don't do anything? What is the purpose of these methods? And why is this file in mainboard? Do we expect the same logic across designs? If so, we should move it to soc?
https://review.coreboot.org/c/coreboot/+/43408/8/src/soc/amd/picasso/acpi/dp... File src/soc/amd/picasso/acpi/dptc.asl:
https://review.coreboot.org/c/coreboot/+/43408/8/src/soc/amd/picasso/acpi/dp... PS8, Line 10: LEqual
Please use ASL2. […]
move this method to src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/dptc.asl and also been modified for ASL2.0.