Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42078 )
Change subject: src/ec/google/chromeec: Get Type-C Mux info from EC (TCPM) ......................................................................
Patch Set 14:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42078/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42078/8//COMMIT_MSG@15 PS8, Line 15: TEST= Tested boots from USB Type-C flash drive and Type-C to Type-A : dongle on Volteer
this code isn't used to boot from USB.
Ack
https://review.coreboot.org/c/coreboot/+/42078/2/src/ec/google/chromeec/ec.c File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/42078/2/src/ec/google/chromeec/ec.c... PS2, Line 1460: PD_CC_DFP_ATTACHED
Ok, then maybe a comment would help explain this, because I read this as `true` for `bool ufp` means […]
Ack
https://review.coreboot.org/c/coreboot/+/42078/11/src/ec/google/chromeec/ec.... File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/42078/11/src/ec/google/chromeec/ec.... PS11, Line 1505: int
how about making this unsigned too? then the check on line 1521 can go away
Ack
https://review.coreboot.org/c/coreboot/+/42078/11/src/ec/google/chromeec/ec_... File src/ec/google/chromeec/ec_acpi.c:
PS11:
The change in this unrelated file is why I think a separate change, underneath this, that has your c […]
Ack