Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42019 )
Change subject: sb/intel/bd82x6x: Make me_common.c a compilation unit
......................................................................
Patch Set 10: Code-Review+1
(1 comment)
Maybe keeping the inline in the declarations allows BUILD_TIMELESS=1 to have the same result?
https://review.coreboot.org/c/coreboot/+/42019/10/src/southbridge/intel/bd82...
File src/southbridge/intel/bd82x6x/me_common.c:
https://review.coreboot.org/c/coreboot/+/42019/10/src/southbridge/intel/bd82...
PS10, Line 89: inline
Maybe keep this in the declaration?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42019
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17e561abf2378632f72d0aa9f0057cb1bee23514
Gerrit-Change-Number: 42019
Gerrit-PatchSet: 10
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Evgeny Zinoviev
me@ch1p.io
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 26 Aug 2020 09:09:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment