1 May
2020
1 May
'20
11:40 a.m.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40721 )
Change subject: nb/intel/sandybridge/raminit: Fix ECC scrub ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40721/3/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit.c:
https://review.coreboot.org/c/coreboot/+/40721/3/src/northbridge/intel/sandy... PS3, Line 390: printk(BIOS_ERR, "RAMINIT: DRAM not clear at addr 0x%lx\n", Another nit: Just reading that messages, it’s not clear it’s about ECC scrubbing.
RAMINIT: ECC scrub failed: DRAM not clear at address 0x%lx\n
clear or cleared?
--
To view, visit https://review.coreboot.org/c/coreboot/+/40721
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia9fcc236fbf73f51fe944c6dda5d22ba9d334ec7
Gerrit-Change-Number: 40721
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Jonathan Kollasch jakllsch@kollasch.net
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 01 May 2020 11:40:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment