Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37178 )
Change subject: soc/amd/common/block/acpimmio: fix ACPIMMIO decode enable function ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37178/8/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/acpimmio_map.h:
https://review.coreboot.org/c/coreboot/+/37178/8/src/soc/amd/common/block/in... PS8, Line 37: I think it's just better to create two functions; acpimmio_decode_enable_pm04 and _pm24.
I believe amd/lamar, from pi/hudson, requires PMx24 too. So you need to differentiate this inside southbridge_early_init().
https://review.coreboot.org/c/coreboot/+/37178/8/src/soc/amd/common/block/in... PS8, Line 39: * in PMx24[1] (older implementations) and PMx04[1] (newer implementations). PMx24[0] ?