build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31597 )
Change subject: security/vboot: Add fmap measurements ......................................................................
Patch Set 15:
(5 comments)
https://review.coreboot.org/#/c/31597/15/src/security/vboot/vboot_crtm.c File src/security/vboot/vboot_crtm.c:
https://review.coreboot.org/#/c/31597/15/src/security/vboot/vboot_crtm.c@98 PS15, Line 98: FMAP_PREFIX "SI_EC // EC firmware") != TPM_SUCCESS) line over 80 characters
https://review.coreboot.org/#/c/31597/15/src/security/vboot/vboot_crtm.c@103 PS15, Line 103: FMAP_PREFIX "SI_GBE // Intel GbE") != TPM_SUCCESS) line over 80 characters
https://review.coreboot.org/#/c/31597/15/src/security/vboot/vboot_crtm.c@108 PS15, Line 108: FMAP_PREFIX "SI_PDR // Platform Data") != TPM_SUCCESS) line over 80 characters
https://review.coreboot.org/#/c/31597/15/src/security/vboot/vboot_crtm.c@300 PS15, Line 300: strncpy(prefix_name, FMAP_PREFIX, TCPA_PCR_HASH_NAME - 1); line over 80 characters
https://review.coreboot.org/#/c/31597/15/src/security/vboot/vboot_crtm.c@302 PS15, Line 302: name, TCPA_PCR_HASH_NAME - sizeof(FMAP_PREFIX) - 1); line over 80 characters