Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47095 )
Change subject: sb/intel/lynxpoint: Use common AHCI library ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47095/2/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/sata.c:
https://review.coreboot.org/c/coreboot/+/47095/2/src/southbridge/intel/lynxp... PS2, Line 116: /* Should be configurable */
is that a TODO? then mark it as such, please
I don't plan on doing it, though.
https://review.coreboot.org/c/coreboot/+/47095/2/src/southbridge/intel/lynxp... PS2, Line 136: if (pch_is_lp()) {
is devsleep really only supported on lp? if H supports it, this should be dropped (in a separate cha […]
No idea. I don't care about such things in refactoring changes (the intention is to preserve behavior)
https://review.coreboot.org/c/coreboot/+/47095/2/src/southbridge/intel/lynxp... PS2, Line 141: ahci_cap_2.supports_device_sleep = 1;
nit: move one line up
why?