James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31363 )
Change subject: mb/gigabyte: add GA-P67A-UD3R ......................................................................
Patch Set 2:
(6 comments)
Still need to add documentation.
https://review.coreboot.org/#/c/31363/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31363/1//COMMIT_MSG@11 PS1, Line 11: flashrom
flashrom’s internal programmmer
Done
https://review.coreboot.org/#/c/31363/1//COMMIT_MSG@20 PS1, Line 20:
How did you create the port? autoport?
Done
https://review.coreboot.org/#/c/31363/1//COMMIT_MSG@38 PS1, Line 38:
What payload and Linux kernel version did you use?
Done
https://review.coreboot.org/#/c/31363/1//COMMIT_MSG@40 PS1, Line 40: - SATA 2
They don't work in vendor BIOS, I assume this is the case.
Done
https://review.coreboot.org/#/c/31363/1/src/mainboard/gigabyte/ga-p67a-ud3r/... File src/mainboard/gigabyte/ga-p67a-ud3r/dsdt.asl:
https://review.coreboot.org/#/c/31363/1/src/mainboard/gigabyte/ga-p67a-ud3r/... PS1, Line 16: #include <arch/acpi.h>
Please add a blank line after this line
Done
https://review.coreboot.org/#/c/31363/1/src/mainboard/gigabyte/ga-p67a-ud3r/... PS1, Line 26: // Some generic macros
Please remove
Done