Reto Buerki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44439 )
Change subject: mb/up/squared: Prompt for MAX_CPUS
......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1:
Please bump MAX_CPUS to 4.
Will do. Do you also prefer a choice like Felix or do you think the current int prompt is fine?
I'm fine with setting it to 4. That's the easiest.
Just to be sure, you both mean without the prompt right? Will this work for setups with only two cores?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44439
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98a3da660052eb7ad2f18b0c7fc0e67a609eac54
Gerrit-Change-Number: 44439
Gerrit-PatchSet: 1
Gerrit-Owner: Reto Buerki
reet@codelabs.ch
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Thu, 13 Aug 2020 11:46:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment