[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Generate ACPI CRAT objects in cb

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47727 )

Change subject: soc/amd/picasso: Generate ACPI CRAT objects in cb
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47727/3/src/include/acpi/acpi.h 
File src/include/acpi/acpi.h:

https://review.coreboot.org/c/coreboot/+/47727/3/src/include/acpi/acpi.h@311 
PS3, Line 311: struct acpi_crat_header
> not using typedefs here might not be completely consistent, but is the better option in the long run […]

I agree with the argument about not using typedefs (not to mention using name_t).  However in this case, I think it will help readability and consistency because it matches the rest of the file, with one other excption.  It also makes the callers to all these functions appear consistent with each other.

IMO it would be better to revamp this entire file as one effort or topic vs. addressing it piecemeal.