Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45911 )
Change subject: drivers/i2c: Add chip driver for GPIO based I2C multiplexer
......................................................................
Patch Set 7: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/45911/7/src/drivers/i2c/gpiomux/mux...
File src/drivers/i2c/gpiomux/mux/mux.c:
https://review.coreboot.org/c/coreboot/+/45911/7/src/drivers/i2c/gpiomux/mux...
PS7, Line 30: config
Checking config for NULL is not required since config_of() guarantees that you don't have a NULL pointer for config.
https://review.coreboot.org/c/coreboot/+/45911/7/src/drivers/i2c/gpiomux/mux...
PS7, Line 30: !dev
Probably weird to check dev after it is already referenced in config_of() above?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45911
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib371108cc6043c133681066bf7bf4b2e00771e8b
Gerrit-Change-Number: 45911
Gerrit-PatchSet: 7
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 13 Oct 2020 06:50:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
