Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42029 )
Change subject: drivers/vpd: Add a function that reads BIOS version from a VPD variable ......................................................................
Patch Set 4:
(2 comments)
The whole idea sounds pretty weird to me - we should not decide or report a "firmware version" by VPD - you should always have that version from the release BIOS code itself, otherwise it may be pretty hard to track "real" versions when the VPD is provisioned seperately.
That also makes me feel this is probably more like a board(family)-specific preference and no need to live in VPD drivers...
Having said that, since this is only adding a new function in a standalone C file, it's probably fine to merge this change.
https://review.coreboot.org/c/coreboot/+/42029/4/src/drivers/vpd/Kconfig File src/drivers/vpd/Kconfig:
https://review.coreboot.org/c/coreboot/+/42029/4/src/drivers/vpd/Kconfig@19 PS4, Line 19: version do you want to change the default name to coreboot_version or firmware_version or smbios_version?
it seems weird to have a generic term "version" without clarification.
https://review.coreboot.org/c/coreboot/+/42029/4/src/drivers/vpd/smbios.c File src/drivers/vpd/smbios.c:
https://review.coreboot.org/c/coreboot/+/42029/4/src/drivers/vpd/smbios.c@32 PS4, Line 32: BIOS SMBIOS ?