Attention is currently required from: Jason Glenesk, Raul Rangel, Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74840 )
Change subject: soc/amd/common/block/lpc/lpc: don't report PCI config IO ports in LPC
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/common/block/lpc/lpc.c:
https://review.coreboot.org/c/coreboot/+/74840/comment/77f5512c_ca905076
PS2, Line 117: IORESOURCE_FIXED
i'm not sure about the IORESOURCE_FIXED flag. when adding subtractive domain MMIO resources, the IORESOURCE_FIXED flag mustn't be set. if IORESOURCE_FIXED is set in the subtractive domain resources to tel lthe resource allocator where it may put non-fixed mmio resources, we get this error
DOMAIN: 0000: Resource ranges:
* EMPTY!!
and after that also some NULL dereferences
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74840
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67458dd14fa89d223e97c2410484c08654a6fab8
Gerrit-Change-Number: 74840
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Fri, 28 Apr 2023 22:19:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment