Attention is currently required from: Shelley Chen, Yu-Ping Wu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69542 )
Change subject: drivers/mrc_cache: Prevent printing errors in expected use cases ......................................................................
Patch Set 1:
(3 comments)
File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/69542/comment/3021ac03_31ce551c PS1, Line 159: printk(BIOS_WARNING, "MRC: failed to locate region type %d\n", type); I feel like you might even want to go further and make this BIOS_DEBUG (with a comment explaining when it would be accepted). WARNING should still be something that you'd want people to pay attention to.
https://review.coreboot.org/c/coreboot/+/69542/comment/855caadd_d5382e12 PS1, Line 180: BIOS_WARNING INFO maybe?
https://review.coreboot.org/c/coreboot/+/69542/comment/9875ac65_9a8987a0 PS1, Line 275: printk(BIOS_WARNING, "MRC: invalid header in '%s'\n", name); Maybe just remove this? Not sure why we need to print again here if the function already prints in all error cases.