Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/28701 )
Change subject: mb: Use 'unsigned int' to bare use of 'unsigned' ......................................................................
mb: Use 'unsigned int' to bare use of 'unsigned'
Change-Id: I3a8e077656df02912b4e67c3947bd5af054a18bf Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/28701 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M src/mainboard/advansus/a785e-i/romstage.c M src/mainboard/amd/bimini_fam10/romstage.c M src/mainboard/amd/mahogany_fam10/romstage.c M src/mainboard/amd/serengeti_cheetah_fam10/romstage.c M src/mainboard/amd/tilapia_fam10/romstage.c M src/mainboard/aopen/dxplplusu/romstage.c M src/mainboard/asus/kcma-d8/romstage.c M src/mainboard/asus/kfsn4-dre/romstage.c M src/mainboard/asus/kgpe-d16/romstage.c M src/mainboard/asus/m4a78-em/romstage.c M src/mainboard/asus/m4a785-m/romstage.c M src/mainboard/asus/m5a88-v/romstage.c M src/mainboard/avalue/eax-785e/romstage.c M src/mainboard/gigabyte/ma785gm/romstage.c M src/mainboard/gigabyte/ma785gmt/romstage.c M src/mainboard/gigabyte/ma78gm/romstage.c M src/mainboard/hp/dl165_g6_fam10/romstage.c M src/mainboard/iei/kino-780am2-fam10/romstage.c M src/mainboard/jetway/pa78vm5/romstage.c M src/mainboard/msi/ms9652_fam10/romstage.c M src/mainboard/supermicro/h8dmr_fam10/romstage.c M src/mainboard/supermicro/h8qme_fam10/romstage.c M src/mainboard/supermicro/h8scm_fam10/romstage.c M src/mainboard/tyan/s2912_fam10/romstage.c 24 files changed, 32 insertions(+), 32 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/mainboard/advansus/a785e-i/romstage.c b/src/mainboard/advansus/a785e-i/romstage.c index e59773f..e73a0e7 100644 --- a/src/mainboard/advansus/a785e-i/romstage.c +++ b/src/mainboard/advansus/a785e-i/romstage.c @@ -54,7 +54,7 @@ #define SERIAL_DEV PNP_DEV(0x2e, W83627HF_SP1)
void activate_spd_rom(const struct mem_controller *ctrl); -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address); extern struct sys_info sysinfo_car;
void activate_spd_rom(const struct mem_controller *ctrl) diff --git a/src/mainboard/amd/bimini_fam10/romstage.c b/src/mainboard/amd/bimini_fam10/romstage.c index d4397b2..5ee1fd6 100644 --- a/src/mainboard/amd/bimini_fam10/romstage.c +++ b/src/mainboard/amd/bimini_fam10/romstage.c @@ -49,7 +49,7 @@ #include "cpu/amd/quadcore/quadcore.c"
void activate_spd_rom(const struct mem_controller *ctrl); -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address); extern struct sys_info sysinfo_car;
void activate_spd_rom(const struct mem_controller *ctrl) diff --git a/src/mainboard/amd/mahogany_fam10/romstage.c b/src/mainboard/amd/mahogany_fam10/romstage.c index e5766c8..0e2db04 100644 --- a/src/mainboard/amd/mahogany_fam10/romstage.c +++ b/src/mainboard/amd/mahogany_fam10/romstage.c @@ -55,7 +55,7 @@ #include "cpu/amd/quadcore/quadcore.c"
void activate_spd_rom(const struct mem_controller *ctrl); -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address); extern struct sys_info sysinfo_car;
void activate_spd_rom(const struct mem_controller *ctrl) { } diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/romstage.c b/src/mainboard/amd/serengeti_cheetah_fam10/romstage.c index ed5a6cb..ad3157f 100644 --- a/src/mainboard/amd/serengeti_cheetah_fam10/romstage.c +++ b/src/mainboard/amd/serengeti_cheetah_fam10/romstage.c @@ -51,7 +51,7 @@ #define SERIAL_DEV PNP_DEV(0x2e, W83627HF_SP1)
void activate_spd_rom(const struct mem_controller *ctrl); -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address); extern struct sys_info sysinfo_car;
static void memreset_setup(void) diff --git a/src/mainboard/amd/tilapia_fam10/romstage.c b/src/mainboard/amd/tilapia_fam10/romstage.c index 89d170c..89e72eb 100644 --- a/src/mainboard/amd/tilapia_fam10/romstage.c +++ b/src/mainboard/amd/tilapia_fam10/romstage.c @@ -53,7 +53,7 @@ #define SERIAL_DEV PNP_DEV(0x2e, IT8718F_SP1)
void activate_spd_rom(const struct mem_controller *ctrl); -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address); extern struct sys_info sysinfo_car;
void activate_spd_rom(const struct mem_controller *ctrl) { } diff --git a/src/mainboard/aopen/dxplplusu/romstage.c b/src/mainboard/aopen/dxplplusu/romstage.c index f203dd1..d18c2ad 100644 --- a/src/mainboard/aopen/dxplplusu/romstage.c +++ b/src/mainboard/aopen/dxplplusu/romstage.c @@ -32,7 +32,7 @@
#define SERIAL_DEV PNP_DEV(0x2e, LPC47M10X2_SP1)
-int spd_read_byte(unsigned device, unsigned address) +int spd_read_byte(unsigned int device, unsigned int address) { return smbus_read_byte(device, address); } diff --git a/src/mainboard/asus/kcma-d8/romstage.c b/src/mainboard/asus/kcma-d8/romstage.c index 3410762..1d616a6 100644 --- a/src/mainboard/asus/kcma-d8/romstage.c +++ b/src/mainboard/asus/kcma-d8/romstage.c @@ -54,10 +54,10 @@ #define SERIAL_1_DEV PNP_DEV(0x2e, W83667HG_A_SP2)
void activate_spd_rom(const struct mem_controller *ctrl); -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address); extern struct sys_info sysinfo_car;
-inline int spd_read_byte(unsigned device, unsigned address) +inline int spd_read_byte(unsigned int device, unsigned int address) { return do_smbus_read_byte(SMBUS_AUX_IO_BASE, device, address); } diff --git a/src/mainboard/asus/kfsn4-dre/romstage.c b/src/mainboard/asus/kfsn4-dre/romstage.c index cc198c6..036f136 100644 --- a/src/mainboard/asus/kfsn4-dre/romstage.c +++ b/src/mainboard/asus/kfsn4-dre/romstage.c @@ -59,10 +59,10 @@ #define GPIO3_DEV PNP_DEV(0x2e, W83627THG_GPIO3)
void activate_spd_rom(const struct mem_controller *ctrl); -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address); extern struct sys_info sysinfo_car;
-int spd_read_byte(unsigned device, unsigned address) +int spd_read_byte(unsigned int device, unsigned int address) { return smbus_read_byte(device, address); } diff --git a/src/mainboard/asus/kgpe-d16/romstage.c b/src/mainboard/asus/kgpe-d16/romstage.c index 95fe630..98bb1ca 100644 --- a/src/mainboard/asus/kgpe-d16/romstage.c +++ b/src/mainboard/asus/kgpe-d16/romstage.c @@ -54,10 +54,10 @@ #define SERIAL_1_DEV PNP_DEV(0x2e, W83667HG_A_SP2)
void activate_spd_rom(const struct mem_controller *ctrl); -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address); extern struct sys_info sysinfo_car;
-int spd_read_byte(unsigned device, unsigned address) +int spd_read_byte(unsigned int device, unsigned int address) { return do_smbus_read_byte(SMBUS_AUX_IO_BASE, device, address); } diff --git a/src/mainboard/asus/m4a78-em/romstage.c b/src/mainboard/asus/m4a78-em/romstage.c index 6392f8f..4e05f0f 100644 --- a/src/mainboard/asus/m4a78-em/romstage.c +++ b/src/mainboard/asus/m4a78-em/romstage.c @@ -55,7 +55,7 @@ #define GPIO_DEV PNP_DEV(0x2e, IT8712F_GPIO)
void activate_spd_rom(const struct mem_controller *ctrl); -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address); extern struct sys_info sysinfo_car;
void activate_spd_rom(const struct mem_controller *ctrl) { } diff --git a/src/mainboard/asus/m4a785-m/romstage.c b/src/mainboard/asus/m4a785-m/romstage.c index dd61c8f..b4f6293 100644 --- a/src/mainboard/asus/m4a785-m/romstage.c +++ b/src/mainboard/asus/m4a785-m/romstage.c @@ -56,7 +56,7 @@ #define GPIO_DEV PNP_DEV(0x2e, IT8712F_GPIO)
void activate_spd_rom(const struct mem_controller *ctrl); -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address); extern struct sys_info sysinfo_car;
void activate_spd_rom(const struct mem_controller *ctrl) { } diff --git a/src/mainboard/asus/m5a88-v/romstage.c b/src/mainboard/asus/m5a88-v/romstage.c index e3f3f3c..fb1a134 100644 --- a/src/mainboard/asus/m5a88-v/romstage.c +++ b/src/mainboard/asus/m5a88-v/romstage.c @@ -55,7 +55,7 @@ #define SERIAL_DEV PNP_DEV(0x4e, IT8721F_SP1)
void activate_spd_rom(const struct mem_controller *ctrl); -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address); extern struct sys_info sysinfo_car;
void activate_spd_rom(const struct mem_controller *ctrl) diff --git a/src/mainboard/avalue/eax-785e/romstage.c b/src/mainboard/avalue/eax-785e/romstage.c index e2ce482..d91776c 100644 --- a/src/mainboard/avalue/eax-785e/romstage.c +++ b/src/mainboard/avalue/eax-785e/romstage.c @@ -54,7 +54,7 @@ #define CLK_DEV PNP_DEV(0x2e, W83627HF_SP1)
void activate_spd_rom(const struct mem_controller *ctrl); -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address); extern struct sys_info sysinfo_car;
void activate_spd_rom(const struct mem_controller *ctrl) diff --git a/src/mainboard/gigabyte/ma785gm/romstage.c b/src/mainboard/gigabyte/ma785gm/romstage.c index 98bc00f..680d279 100644 --- a/src/mainboard/gigabyte/ma785gm/romstage.c +++ b/src/mainboard/gigabyte/ma785gm/romstage.c @@ -52,7 +52,7 @@ #define GPIO_DEV PNP_DEV(0x2e, IT8718F_GPIO)
void activate_spd_rom(const struct mem_controller *ctrl); -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address); extern struct sys_info sysinfo_car;
void activate_spd_rom(const struct mem_controller *ctrl) { } diff --git a/src/mainboard/gigabyte/ma785gmt/romstage.c b/src/mainboard/gigabyte/ma785gmt/romstage.c index 81d4c6b..642f70b 100644 --- a/src/mainboard/gigabyte/ma785gmt/romstage.c +++ b/src/mainboard/gigabyte/ma785gmt/romstage.c @@ -52,7 +52,7 @@ #define GPIO_DEV PNP_DEV(0x2e, IT8718F_GPIO)
void activate_spd_rom(const struct mem_controller *ctrl); -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address); extern struct sys_info sysinfo_car;
void activate_spd_rom(const struct mem_controller *ctrl) { } diff --git a/src/mainboard/gigabyte/ma78gm/romstage.c b/src/mainboard/gigabyte/ma78gm/romstage.c index 9f4dd44..923cfbc 100644 --- a/src/mainboard/gigabyte/ma78gm/romstage.c +++ b/src/mainboard/gigabyte/ma78gm/romstage.c @@ -55,7 +55,7 @@ #define GPIO_DEV PNP_DEV(0x2e, IT8718F_GPIO)
void activate_spd_rom(const struct mem_controller *ctrl); -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address); extern struct sys_info sysinfo_car;
void activate_spd_rom(const struct mem_controller *ctrl) { } diff --git a/src/mainboard/hp/dl165_g6_fam10/romstage.c b/src/mainboard/hp/dl165_g6_fam10/romstage.c index 116a53a..fc922f4 100644 --- a/src/mainboard/hp/dl165_g6_fam10/romstage.c +++ b/src/mainboard/hp/dl165_g6_fam10/romstage.c @@ -57,7 +57,7 @@ #define RTC_DEV PNP_DEV(0x4e, PC87417_RTC)
void activate_spd_rom(const struct mem_controller *ctrl); -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address); extern struct sys_info sysinfo_car;
inline void activate_spd_rom(const struct mem_controller *ctrl) @@ -71,7 +71,7 @@ outb((val & ~3) | ctrl->spd_switch_addr, 0xcd7); }
-inline int spd_read_byte(unsigned device, unsigned address) +inline int spd_read_byte(unsigned int device, unsigned int address) { return smbus_read_byte(device, address); } diff --git a/src/mainboard/iei/kino-780am2-fam10/romstage.c b/src/mainboard/iei/kino-780am2-fam10/romstage.c index 866a9a8..5693cee 100644 --- a/src/mainboard/iei/kino-780am2-fam10/romstage.c +++ b/src/mainboard/iei/kino-780am2-fam10/romstage.c @@ -54,7 +54,7 @@ #define SERIAL_DEV PNP_DEV(0x2e, F71859_SP1)
void activate_spd_rom(const struct mem_controller *ctrl); -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address); extern struct sys_info sysinfo_car;
void activate_spd_rom(const struct mem_controller *ctrl) { } diff --git a/src/mainboard/jetway/pa78vm5/romstage.c b/src/mainboard/jetway/pa78vm5/romstage.c index 760fc13..1041696 100644 --- a/src/mainboard/jetway/pa78vm5/romstage.c +++ b/src/mainboard/jetway/pa78vm5/romstage.c @@ -59,7 +59,7 @@ #endif
void activate_spd_rom(const struct mem_controller *ctrl); -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address); extern struct sys_info sysinfo_car;
void activate_spd_rom(const struct mem_controller *ctrl) { } diff --git a/src/mainboard/msi/ms9652_fam10/romstage.c b/src/mainboard/msi/ms9652_fam10/romstage.c index 0b5d935..7848e9e 100644 --- a/src/mainboard/msi/ms9652_fam10/romstage.c +++ b/src/mainboard/msi/ms9652_fam10/romstage.c @@ -49,12 +49,12 @@ #define SERIAL_DEV PNP_DEV(0x2e, W83627EHG_SP1)
void activate_spd_rom(const struct mem_controller *ctrl); -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address); extern struct sys_info sysinfo_car;
void activate_spd_rom(const struct mem_controller *ctrl) { }
-inline int spd_read_byte(unsigned device, unsigned address) +inline int spd_read_byte(unsigned int device, unsigned int address) { return smbus_read_byte(device, address); } diff --git a/src/mainboard/supermicro/h8dmr_fam10/romstage.c b/src/mainboard/supermicro/h8dmr_fam10/romstage.c index c360389..d5506df 100644 --- a/src/mainboard/supermicro/h8dmr_fam10/romstage.c +++ b/src/mainboard/supermicro/h8dmr_fam10/romstage.c @@ -53,12 +53,12 @@ #define SUPERIO_DEV PNP_DEV(0x2e, 0)
void activate_spd_rom(const struct mem_controller *ctrl); -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address); extern struct sys_info sysinfo_car;
void activate_spd_rom(const struct mem_controller *ctrl) { }
-inline int spd_read_byte(unsigned device, unsigned address) +inline int spd_read_byte(unsigned int device, unsigned int address) { return smbus_read_byte(device, address); } diff --git a/src/mainboard/supermicro/h8qme_fam10/romstage.c b/src/mainboard/supermicro/h8qme_fam10/romstage.c index ddbb97c..f438400 100644 --- a/src/mainboard/supermicro/h8qme_fam10/romstage.c +++ b/src/mainboard/supermicro/h8qme_fam10/romstage.c @@ -55,7 +55,7 @@ #define SMBUS_SWITCH2 0x72
void activate_spd_rom(const struct mem_controller *ctrl); -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address); extern struct sys_info sysinfo_car;
inline void activate_spd_rom(const struct mem_controller *ctrl) @@ -64,7 +64,7 @@ smbus_send_byte(SMBUS_SWITCH2, (5 >> 4) & 0x0f); }
-inline int spd_read_byte(unsigned device, unsigned address) +inline int spd_read_byte(unsigned int device, unsigned int address) { return smbus_read_byte(device, address); } diff --git a/src/mainboard/supermicro/h8scm_fam10/romstage.c b/src/mainboard/supermicro/h8scm_fam10/romstage.c index 6850995..a3d3cea 100644 --- a/src/mainboard/supermicro/h8scm_fam10/romstage.c +++ b/src/mainboard/supermicro/h8scm_fam10/romstage.c @@ -51,7 +51,7 @@ #include "cpu/amd/quadcore/quadcore.c"
void activate_spd_rom(const struct mem_controller *ctrl); -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address); extern struct sys_info sysinfo_car;
void activate_spd_rom(const struct mem_controller *ctrl) diff --git a/src/mainboard/tyan/s2912_fam10/romstage.c b/src/mainboard/tyan/s2912_fam10/romstage.c index 373ff71..0b47f9d 100644 --- a/src/mainboard/tyan/s2912_fam10/romstage.c +++ b/src/mainboard/tyan/s2912_fam10/romstage.c @@ -49,12 +49,12 @@ #define SERIAL_DEV PNP_DEV(0x2e, W83627HF_SP1)
void activate_spd_rom(const struct mem_controller *ctrl); -int spd_read_byte(unsigned device, unsigned address); +int spd_read_byte(unsigned int device, unsigned int address); extern struct sys_info sysinfo_car;
void activate_spd_rom(const struct mem_controller *ctrl) { }
-inline int spd_read_byte(unsigned device, unsigned address) +inline int spd_read_byte(unsigned int device, unsigned int address) { return smbus_read_byte(device, address); }