Attention is currently required from: Robert Zieba, Raul Rangel, Rob Barnes, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66573 )
Change subject: util/amdfwtool/amdfwread: Fix AMDFW_OPT* bit mask
......................................................................
Patch Set 6:
(2 comments)
File util/amdfwtool/amdfwread.c:
https://review.coreboot.org/c/coreboot/+/66573/comment/52dcd472_60628972
PS5, Line 191: }
We should probably have a `default` case. […]
Done. Made some updates to option handling to include default case as well.
https://review.coreboot.org/c/coreboot/+/66573/comment/b381065d_60c9d1fc
PS5, Line 198: selected_functions |= opt;
I would be inclined to just remove the BIT(31) in this CL since it causes problems in https://review […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66573
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d88669bace45f3332c5e56527516b2f38295a48
Gerrit-Change-Number: 66573
Gerrit-PatchSet: 6
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 02 Sep 2022 20:26:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Robert Zieba
robertzieba@google.com
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment