Nick Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45860 )
Change subject: mb/google/volteer: Add a DPTF policy for Eldrid
......................................................................
Patch Set 26:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45860/22//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45860/22//COMMIT_MSG@12
PS22, Line 12:
Unfortunately, the access to the bug report is restricted, so please add the information to the comm […]
Done
https://review.coreboot.org/c/coreboot/+/45860/22/src/mainboard/google/volte...
File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45860/22/src/mainboard/google/volte...
PS22, Line 79: register "policies.passive[0]" = "DPTF_PASSIVE(CPU,CPU,95,5000)"
: register "policies.passive[3]" = "DPTF_PASSIVE(CPU,TEMP_SENSOR_2,60,6000)"
If you're not using TSR 0, 1, or 3, then you'll need it to look like: […]
Done
https://review.coreboot.org/c/coreboot/+/45860/22/src/mainboard/google/volte...
PS22, Line 82: ## Critical Policy
: register "policies.critical[0]" = "DPTF_CRITICAL(CPU,100,SHUTDOWN)"
: register "policies.critical[3]" = "DPTF_CRITICAL(TEMP_SENSOR_2,80,SHUTDOWN)"
If you're not using TSR 0, 1, or 3, then you'll need it to look like: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45860
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I99e429b90ed7de08385fe51ca742865b1266eef9
Gerrit-Change-Number: 45860
Gerrit-PatchSet: 26
Gerrit-Owner: Nick Chen
nick_xr_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Keith Short
keithshort@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Keith Short
keithshort@chromium.org
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Comment-Date: Wed, 21 Oct 2020 06:19:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Nick Chen
nick_xr_chen@wistron.corp-partner.google.com
Gerrit-MessageType: comment