Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38800 )
Change subject: soc/intel/common: Check prerequisites for GLOBAL_RESET command
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38800/7/src/soc/intel/common/block/...
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/38800/7/src/soc/intel/common/block/...
PS7, Line 613: if (cse_is_hfs1_cws_normal() && cse_is_hfs1_com_normal())
: return 1;
: else if (cse_is_hfs3_fw_sku_custom() && cse_is_hfs1_cws_normal()
: && (cse_is_hfs1_com_soft_temp_disable() || cse_is_hfs1_com_secover_mei_msg()))
: return 1;
:
: return 0;
Add a comment to explain the prerequisites.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38800
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia583e4033f15ec20e942202fa78e7884cf370ce4
Gerrit-Change-Number: 38800
Gerrit-PatchSet: 14
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 15 Mar 2020 10:37:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-MessageType: comment