Attention is currently required from: Martin Roth, Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48528 )
Change subject: soc/amd/cezanne: Add PSP integration for cezanne ......................................................................
Patch Set 28:
(7 comments)
File src/mainboard/amd/majolica/Kconfig:
https://review.coreboot.org/c/coreboot/+/48528/comment/fe8eef59_5d415fe2 PS21, Line 21: config AMD_FWM_POSITION_INDEX
this should be in the majolica-related patch. […]
Done
File src/soc/amd/cezanne/Kconfig:
https://review.coreboot.org/c/coreboot/+/48528/comment/365835a2_7479ed72 PS7, Line 104: config AMDFW_OUTSIDE_CBFS : bool : default n : help : The AMDFW (PSP) is typically locatable in cbfs. Select this : option to manually attach the generated amdfw.rom outside of : cbfs. The location is selected by the FWM position.
this can be removed, since it's unused and was implemented in a very unsafe way when i removed it fr […]
Done
File src/soc/amd/cezanne/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48528/comment/f402fb06_03859818 PS7, Line 64: #PSP_SOFTFUSE_BITS += 29
this probably shouldn't be commented out
Done
File src/soc/amd/cezanne/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48528/comment/aebc7a29_6f43b529 PS13, Line 138: OPT_PSP_APCB_FILES= --instance 0 --apcb $(APCB_SOURCES) --instance 10 --apcb $(APCB_SOURCES_RECOVERY)
this and the code in amdfwtool possibly needs some change to support this properly. […]
Done
File src/soc/amd/cezanne/fw.cfg:
https://review.coreboot.org/c/coreboot/+/48528/comment/671158d8_79c3ba68 PS7, Line 11: #4? : #PSPNVRAM_FILE PspNvramCZN_2.bin
please remove instead of commenting out
Done
File src/soc/amd/cezanne/fw.cfg:
https://review.coreboot.org/c/coreboot/+/48528/comment/15e9b8a7_5ff34e93 PS9, Line 3: 3rdparty/amd_blobs/cezanne/PSP
These files aren't checked into this directory yet, so the guybrush build will probably keep failing […]
Done
File src/soc/amd/cezanne/fw.cfg:
https://review.coreboot.org/c/coreboot/+/48528/comment/e0b2cef8_db7972ef PS12, Line 56: ## BDT : #0x60 : #APCB_CZN_D4_Updatable.bin : #0x68 : #APCB_CZN_D4_DefaultRecovery.bin : #0x68 : #APCB_CZN_D4_Updatable_68.bin : #0x61 : #0x62 : #0x63 : #APOB_NV_FILE APOB_NV_RV.bin
those should be removed
Done