Matt Parnell has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34946 )
Change subject: WIP: add src/mainboard/hp/spectre_x360_13t_ae000 port ......................................................................
Patch Set 26:
(5 comments)
Patch Set 24:
(1 comment)
These concerns should all be addressed, once I make jenkins happy with my whitespace.
https://review.coreboot.org/c/coreboot/+/34946/24//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34946/24//COMMIT_MSG@9 PS24, Line 9: Signed-off-by: Matt Parnell mparnell@gmail.com
Please move this right below the Change-Id line.
Ack
https://review.coreboot.org/c/coreboot/+/34946/24/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/memory.h:
PS24:
This isn't needed as you don't use variants
Cleaned it up.
https://review.coreboot.org/c/coreboot/+/34946/24/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/memory.c:
PS24:
This can be inside romstage. […]
Done
https://review.coreboot.org/c/coreboot/+/34946/24/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/romstage.c:
https://review.coreboot.org/c/coreboot/+/34946/24/src/mainboard/hp/spectre_x... PS24, Line 53: memory_params
once you move the memory data into this file, this struct can be removed. […]
Done
https://review.coreboot.org/c/coreboot/+/34946/24/src/mainboard/hp/spectre_x... PS24, Line 75: mem_cfg->MemorySpdPtr10 = 0;
Always run this for now, as bringing up one channel at a time is easier.
Good to know, thank you.