Patch Set 24:

(1 comment)

These concerns should all be addressed, once I make jenkins happy with my whitespace.

View Change

5 comments:

• Commit Message:

  • Patch Set #24, Line 9: Signed-off-by: Matt Parnell <mparnell@gmail.com>

    Please move this right below the Change-Id line.

    Ack

• File src/mainboard/hp/spectre_x360_13t_ae000/memory.h:

  • Patch Set #24:

    This isn't needed as you don't use variants

    Cleaned it up.

• File src/mainboard/hp/spectre_x360_13t_ae000/memory.c:

  • Patch Set #24:

    This can be inside romstage. […]

    Done

• File src/mainboard/hp/spectre_x360_13t_ae000/romstage.c:

  • Patch Set #24, Line 53: memory_params

    once you move the memory data into this file, this struct can be removed. […]

    Done

  • Patch Set #24, Line 75: mem_cfg->MemorySpdPtr10 = 0;

    Always run this for now, as bringing up one channel at a time is easier.

    Good to know, thank you.

To view, visit change 34946. To unsubscribe, or for help writing mail filters, visit settings.