Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46864 )
Change subject: soc/intel: Add a driver for CNVi WiFi/BT controllers
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46864/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/cnvi/cnvi.c:
https://review.coreboot.org/c/coreboot/+/46864/1/src/soc/intel/common/block/...
PS1, Line 10: CNVW
not for this change but I wonder if we should start putting these in a common header like pci ids.
That might be helpful. Helps use the same names across all platforms. Also, can be used in other code in case it is not generated by SSDT.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46864
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69a832be918d4b9f4fbe3a40913d4542a457a77c
Gerrit-Change-Number: 46864
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 28 Oct 2020 20:15:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment