Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43919 )
Change subject: mb/asrock/h110m: Relocate devicetree settings ......................................................................
Patch Set 2:
Patch Set 2:
Why did you abandon these changes?
Among other reasons, there were too many discrepancies between PCIe root port settings in FSP and devicetree. I didn't look into as to why. Since each board would need to be inspected in detail, I decided to drop the changes.
Another reason is that several of them got rubberstamped (+2'd without proper review). The original message said "Relocate FSP devicetree settings", but e.g. CB:43874 moved non-FSP I2C settings around yet it got a +2.
In any case, I re-checked this change and it doesn't have weird problems. I'll restore it, if you like it then we can get it in.