17 Aug
2019
17 Aug
'19
12:26 a.m.
Peter Tsung Ho Wu has posted comments on this change. ( https://review.coreboot.org/c/em100/+/34917 )
Change subject: em100: Remove unused assignment ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Shouldn't we check the return value instead?
That's a good idea. I don't know what to put in the check though.
Let's assume read_sdram() can go wrong. We can check if it is True and if not, skip the line #834 and #835.
--
To view, visit https://review.coreboot.org/c/em100/+/34917
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: Ibcdde9548d5ecd55ebecf7d824cf679a28e2322c
Gerrit-Change-Number: 34917
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Peter Tsung Ho Wu tsung@amazon.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 16 Aug 2019 22:26:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment