Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35377 )
Change subject: lib/fmap: Cache FMAP in cbmem ......................................................................
Patch Set 9: Code-Review+1
(2 comments)
LGTM to me now (name-bikeshedding isn't blocking), let's see what Aaron says.
https://review.coreboot.org/c/coreboot/+/35377/9/src/lib/fmap.c File src/lib/fmap.c:
https://review.coreboot.org/c/coreboot/+/35377/9/src/lib/fmap.c@221 PS9, Line 221: /* Don't set fmap_cache so that find_fmap_directory will use regular path */ nit: maybe that's just me but I'd avoid multiple lines without braces around them, even if the other line is a comment. I'd put the comment either on the line with the if() or above it.
https://review.coreboot.org/c/coreboot/+/35377/9/src/lib/fmap.c@231 PS9, Line 231: fmap_register_cache nit: Sorry, I meant "register" for the other one. To me, "register" says "find this thing that already exists and hook it up". For this function here I think setup_cache() was a better fit.