Attention is currently required from: Johnny Lin, Morgan Jang, Patrick Rudolph.
Angel Pons has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85318?usp=email )
The change is no longer submittable: All-Comments-Resolved and Code-Review are unsatisfied now.
Change subject: mb/ocp/tiogapass: Implement mainboard_dimm_slot_exists
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File src/mainboard/ocp/tiogapass/romstage.c:
https://review.coreboot.org/c/coreboot/+/85318/comment/152cfc3a_c8de3c2e?usp... :
PS6, Line 75: if (dimm >= 2)
Does this board have 1 or 2 DIMMs per channel?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85318?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I31cb4a89aa11258ac04eb69a0e9c86f258280484
Gerrit-Change-Number: 85318
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Comment-Date: Wed, 04 Dec 2024 11:32:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes