Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39374 )
Change subject: soc/{apl,glk}: Allow to select the primary graphics device
......................................................................
Patch Set 33:
(1 comment)
File src/soc/intel/apollolake/chip.h:
https://review.coreboot.org/c/coreboot/+/39374/comment/8e006c7a_41dcdd9d
PS17, Line 45: PRIMARY_AUTO = 0,
: PRIMARY_IGD = 2,
: PRIMARY_PCI = 3,
I have stumbled across this again... […]
Just to be sure, you are using the latest public FSP binary?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39374
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idcd117217cf412ee0722aff52db4b3c8ec2a226c
Gerrit-Change-Number: 39374
Gerrit-PatchSet: 33
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Thu, 17 Mar 2022 10:57:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment